[webkit-changes] [WebKit/WebKit] 74d753: AX: Cache new AXProperty::InsideLink instead of bo...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74d7538c2d7f0da6e3b7d38990ef834d1598acfa
      https://github.com/WebKit/WebKit/commit/74d7538c2d7f0da6e3b7d38990ef834d1598acfa
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/AccessibilityProgressIndicator.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: Cache new AXProperty::InsideLink instead of both AXPropertyName::IsVisited and AXPropertyName::IsUnvisited
https://bugs.webkit.org/show_bug.cgi?id=255644
rdar://problem/108244131

Reviewed by Chris Fleizach.

We can cache one fewer property while serving the same information.

This patch also moves `isProgressIndicator` to AXCoreObject since its
value is dependent only on AXCoreObject::roleValue(). This saves another
property.

* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isProgressIndicator const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::insideLink const):
(WebCore::AccessibilityObject::isUnvisited const): Deleted.
(WebCore::AccessibilityObject::isVisited const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::isProgressIndicator const):
(WebCore::AXCoreObject::isUnvisited const):
(WebCore::AXCoreObject::isVisited const):
* Source/WebCore/accessibility/AccessibilityProgressIndicator.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/263130@main