[webkit-changes] [WebKit/WebKit] 219a3d: [WebGPU] Shader module shouldn't try to read const...

Tadeu Zagallo noreply at github.com
Wed Apr 19 01:48:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 219a3d11b718f56768d5bd56b44a79cc67317bef
      https://github.com/WebKit/WebKit/commit/219a3d11b718f56768d5bd56b44a79cc67317bef
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-04-19 (Wed, 19 Apr 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WebGPU] Shader module shouldn't try to read constants if there's no library
https://bugs.webkit.org/show_bug.cgi?id=255599
rdar://108197471

Reviewed by Mike Wyrzykowski.

We currently crash when creating a render pipeline and providing constant overrides
unless the module was early compiled (which is currently disabled). This is a trivial
change to check if we have a successfully compiled library before trying to read
the constants from it.

* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::getNamedFunction const):

Canonical link: https://commits.webkit.org/263120@main




More information about the webkit-changes mailing list