[webkit-changes] [WebKit/WebKit] 29010c: Add factory functions for InputType subclasses

Chris Dumez noreply at github.com
Tue Apr 18 20:36:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29010c0f998e5e582ca078f0584d621044934c5a
      https://github.com/WebKit/WebKit/commit/29010c0f998e5e582ca078f0584d621044934c5a
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M Source/WebCore/html/ButtonInputType.h
    M Source/WebCore/html/CheckboxInputType.h
    M Source/WebCore/html/ColorInputType.h
    M Source/WebCore/html/DateInputType.h
    M Source/WebCore/html/DateTimeLocalInputType.h
    M Source/WebCore/html/EmailInputType.h
    M Source/WebCore/html/FileInputType.h
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HiddenInputType.h
    M Source/WebCore/html/ImageInputType.h
    M Source/WebCore/html/InputType.cpp
    M Source/WebCore/html/InputType.h
    M Source/WebCore/html/MonthInputType.h
    M Source/WebCore/html/NumberInputType.h
    M Source/WebCore/html/PasswordInputType.h
    M Source/WebCore/html/RadioInputType.h
    M Source/WebCore/html/RangeInputType.h
    M Source/WebCore/html/ResetInputType.h
    M Source/WebCore/html/SearchInputType.h
    M Source/WebCore/html/SubmitInputType.h
    M Source/WebCore/html/TelephoneInputType.h
    M Source/WebCore/html/TextInputType.h
    M Source/WebCore/html/TimeInputType.h
    M Source/WebCore/html/URLInputType.h
    M Source/WebCore/html/WeekInputType.h

  Log Message:
  -----------
  Add factory functions for InputType subclasses
https://bugs.webkit.org/show_bug.cgi?id=255630

Reviewed by Darin Adler.

Add factory functions for InputType subclasses. It is a little risky to have
RefCounted subclasses with a public constructor.

* Source/WebCore/html/ButtonInputType.h:
* Source/WebCore/html/CheckboxInputType.h:
* Source/WebCore/html/ColorInputType.h:
* Source/WebCore/html/DateInputType.h:
* Source/WebCore/html/DateTimeLocalInputType.h:
* Source/WebCore/html/EmailInputType.h:
* Source/WebCore/html/FileInputType.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::initializeInputType):
* Source/WebCore/html/HiddenInputType.h:
* Source/WebCore/html/ImageInputType.h:
* Source/WebCore/html/InputType.cpp:
(WebCore::createInputType):
(WebCore::InputType::createIfDifferent):
(WebCore::InputType::createText): Deleted.
* Source/WebCore/html/InputType.h:
* Source/WebCore/html/MonthInputType.h:
* Source/WebCore/html/NumberInputType.h:
* Source/WebCore/html/PasswordInputType.h:
* Source/WebCore/html/RadioInputType.h:
* Source/WebCore/html/RangeInputType.h:
* Source/WebCore/html/ResetInputType.h:
* Source/WebCore/html/SearchInputType.h:
* Source/WebCore/html/SubmitInputType.h:
* Source/WebCore/html/TelephoneInputType.h:
* Source/WebCore/html/TextInputType.h:
* Source/WebCore/html/TimeInputType.h:
* Source/WebCore/html/URLInputType.h:
* Source/WebCore/html/WeekInputType.h:

Canonical link: https://commits.webkit.org/263114@main




More information about the webkit-changes mailing list