[webkit-changes] [WebKit/WebKit] a387be: Use CreationData in FreeType font implementation

Don Olmstead noreply at github.com
Tue Apr 18 11:01:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a387beb77af3254490adc82a17eb9a3c92b29d6a
      https://github.com/WebKit/WebKit/commit/a387beb77af3254490adc82a17eb9a3c92b29d6a
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/FontCustomPlatformData.h
    M Source/WebCore/platform/graphics/FontPlatformData.cpp
    M Source/WebCore/platform/graphics/FontPlatformData.h
    M Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
    M Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
    M Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp
    M Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp

  Log Message:
  -----------
  Use CreationData in FreeType font implementation
https://bugs.webkit.org/show_bug.cgi?id=255476

Reviewed by Michael Catanzaro.

FreeType is the only Font backend that isn't using `CreationData`. Use
it to share implementation and behavior of `FontCustomPlatformData`.

During development found that `m_renderingResourceIdentifier` wasn't
initialized for FreeType in `FontCustomPlatformData`. Also saw that
the Windows implementation of `Font::platformCreateScaledFont` did not
propagate the platform data.

* Source/WebCore/platform/graphics/FontCustomPlatformData.h:
* Source/WebCore/platform/graphics/FontPlatformData.cpp:
* Source/WebCore/platform/graphics/FontPlatformData.h:
* Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
* Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:
* Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:
* Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp:

Canonical link: https://commits.webkit.org/263084@main




More information about the webkit-changes mailing list