[webkit-changes] [WebKit/WebKit] fd6a43: [WGSL] Call expressions can't always use the infer...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd6a43bbb6911e717868e413f864a3c0c0cf65c9
      https://github.com/WebKit/WebKit/commit/fd6a43bbb6911e717868e413f864a3c0c0cf65c9
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-04-18 (Tue, 18 Apr 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Call expressions can't always use the inferred type for serialization
https://bugs.webkit.org/show_bug.cgi?id=255516
rdar://108135679

Reviewed by Mike Wyrzykowski.

In https://commits.webkit.org/262528@main we started using the inferred type for
call expressions' targets when serializing. That was necessary when constructing
parameterized without explicitly providing the content type, since that relies on
type inference. However, the type of CallExpression::target is a bit misleading,
since it claims to be a type, but isn't always a type. In order to solve that, we
check if target is a valid type name, otherwise we write out the string value of
the target as is.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/263067@main