[webkit-changes] [WebKit/WebKit] c67536: [Re-landing] Simplify the ARM64E code because NUMB...

Commit Queue noreply at github.com
Mon Apr 17 18:45:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c67536ceb17301b3e1aed650c0e304ec1bb5795a
      https://github.com/WebKit/WebKit/commit/c67536ceb17301b3e1aed650c0e304ec1bb5795a
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/ARM64EAssembler.h
    M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h

  Log Message:
  -----------
  [Re-landing] Simplify the ARM64E code because NUMBER_OF_ADDRESS_ENCODING_INSTRUCTIONS is always 4.
https://bugs.webkit.org/show_bug.cgi?id=255497
rdar://108108389

Reviewed by Justin Michaud.

The code doesn't need to be conditional because for ARM64E, NUMBER_OF_ADDRESS_ENCODING_INSTRUCTIONS always equals 4.
The previous patch removed ARM64EAssembler::MAX_POINTER_BITS.  Turns out, this is needed to override the one in
ARM64Assembler.  This patch keeps it, which fixes all the regressions from the previous landing.

* Source/JavaScriptCore/assembler/ARM64EAssembler.h:
(JSC::ARM64EAssembler::linkPointer):
(JSC::ARM64EAssembler::setPointer):
(JSC::ARM64EAssembler::readPointer):
(JSC::ARM64EAssembler::readCallTarget):
* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::moveWithFixedWidth):

Canonical link: https://commits.webkit.org/263050@main




More information about the webkit-changes mailing list