[webkit-changes] [WebKit/WebKit] 16e36e: clang-cl reports "error: reference to 'UUID' is am...

Fujii Hironori noreply at github.com
Mon Apr 17 15:32:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16e36e6bc5e6ba586ec78fcb05297928fdba0eaa
      https://github.com/WebKit/WebKit/commit/16e36e6bc5e6ba586ec78fcb05297928fdba0eaa
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M Source/WTF/wtf/Forward.h
    M Source/WebKit/UIProcess/API/APIUserInitiatedAction.h
    M Source/WebKit/UIProcess/API/C/WKNotificationManager.cpp

  Log Message:
  -----------
  clang-cl reports "error: reference to 'UUID' is ambiguous" for Windows port
https://bugs.webkit.org/show_bug.cgi?id=234696

Reviewed by Yusuke Suzuki.

Including <windows.h> defines `UUID` in the global scope. This
conflicted with "using WTF::UUID;" in <wtf/Forward.h>. For the
workaround, define `UUID` in each namespace that is using it in
<wtf/Forward.h>.

* Source/WTF/wtf/Forward.h:
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerProviderDidClickNotification_b):

Canonical link: https://commits.webkit.org/263042@main




More information about the webkit-changes mailing list