[webkit-changes] [WebKit/WebKit] da253c: Serialize an optional<double> instead of an NSDict...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da253c7b2296c8a10d598a0df293db636fd52da7
      https://github.com/WebKit/WebKit/commit/da253c7b2296c8a10d598a0df293db636fd52da7
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M Source/WebCore/editing/cocoa/DataDetection.h
    M Source/WebCore/editing/cocoa/DataDetection.mm
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/FrameLoaderClient.h
    M Source/WebKit/Shared/Cocoa/LoadParametersCocoa.mm
    M Source/WebKit/Shared/LoadParameters.h
    M Source/WebKit/UIProcess/API/APIUIClient.h
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm
    M Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm

  Log Message:
  -----------
  Serialize an optional<double> instead of an NSDictionary for DataDetection reference date
https://bugs.webkit.org/show_bug.cgi?id=255541
rdar://108108131

Reviewed by Tim Horton.

This fixes a regression from 262558 at main with a test that would hit the crash.

* Source/WebCore/editing/cocoa/DataDetection.h:
* Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::extractReferenceDate):
(WebCore::DataDetection::detectContentInRange):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebKit/Shared/Cocoa/LoadParametersCocoa.mm:
(WebKit::LoadParameters::platformEncode const):
(WebKit::LoadParameters::platformDecode):
* Source/WebKit/Shared/LoadParameters.h:
* Source/WebKit/UIProcess/API/APIUIClient.h:
(API::UIClient::dataDetectionReferenceDate):
(API::UIClient::dataDetectionContext): Deleted.
* Source/WebKit/UIProcess/Cocoa/UIDelegate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::dataDetectionReferenceDate):
(WebKit::UIDelegate::UIClient::dataDetectionContext): Deleted.
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::addPlatformLoadParameters):
* Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:
(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dataDetectionReferenceDate):
(WebKit::WebFrameLoaderClient::dataDetectionContext): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::platformDidReceiveLoadParameters):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::detectDataInAllFrames):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::dataDetectionReferenceDate const):
(WebKit::WebPage::dataDetectionContext const): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
(-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
* Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/263037@main