[webkit-changes] [WebKit/WebKit] 3ac060: Web Inspector: Elements tab: Event badge popover d...

Razvan Caliman - Apple noreply at github.com
Mon Apr 17 00:24:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ac060544790d4b26eeb70a20de0ae55722008cb
      https://github.com/WebKit/WebKit/commit/3ac060544790d4b26eeb70a20de0ae55722008cb
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

  Log Message:
  -----------
  Web Inspector: Elements tab: Event badge popover does not dismiss when clicking its trigger again while it is visible
https://bugs.webkit.org/show_bug.cgi?id=255463

Reviewed by Devin Rousso.

A popover will auto-dismiss when clicking outside it.
Popover triggers are always outside them.

When it's done dismissing, after a CSS transition ends,
a popover will call `didDismissPopover()` on its delegate.

This patch uses this mechanism to clear the instance for a
visible event badge popover and avoid showing a popover again
when its trigger is clicked repeatedly.

* Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.async _handleEventBadgeClicked):
(WI.DOMTreeElement.async _handleEventBadgeClicked.popover.windowResizeHandler): Deleted.

Canonical link: https://commits.webkit.org/263015@main




More information about the webkit-changes mailing list