[webkit-changes] [WebKit/WebKit] f204f5: Migrate to ALLOW_***_BEGIN/END instead of #pragma ...

Myles C. Maxfield noreply at github.com
Fri Apr 14 15:27:37 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f204f5437c4e4edbe6551c2ad6dc58be653ba834
      https://github.com/WebKit/WebKit/commit/f204f5437c4e4edbe6551c2ad6dc58be653ba834
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/LinkBuffer.h
    M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
    M Source/WTF/wtf/Assertions.cpp
    M Source/WTF/wtf/FileSystem.cpp
    M Source/WTF/wtf/PrintStream.cpp
    M Source/WTF/wtf/SHA1.cpp
    M Source/WTF/wtf/darwin/OSLogPrintStream.mm
    M Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.mm
    M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp
    M Source/WebCore/PAL/pal/system/mac/PopupMenu.mm
    M Source/WebCore/PAL/pal/system/mac/WebPanel.mm
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Source/WebCore/crypto/CommonCryptoUtilities.cpp
    M Source/WebCore/crypto/mac/CryptoAlgorithmAES_GCMMac.cpp
    M Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp
    M Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp
    M Source/WebCore/platform/audio/mac/AudioSessionMac.mm
    M Source/WebCore/platform/cocoa/DragImageCocoa.mm
    M Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/AVOutputDeviceMenuControllerTargetPicker.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
    M Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp
    M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp
    M Source/WebCore/platform/graphics/mac/GraphicsChecksMac.cpp
    M Source/WebCore/platform/graphics/mac/IconMac.mm
    M Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm
    M Source/WebCore/platform/graphics/mac/WebKitNSImageExtras.mm
    M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm
    M Source/WebCore/platform/gtk/RenderThemeGadget.cpp
    M Source/WebCore/platform/ios/LegacyTileGrid.mm
    M Source/WebCore/platform/ios/PasteboardIOS.mm
    M Source/WebCore/platform/ios/ScrollViewIOS.mm
    M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
    M Source/WebCore/platform/mac/DataDetectorHighlight.mm
    M Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm
    M Source/WebCore/platform/mac/PasteboardMac.mm
    M Source/WebCore/platform/mac/PasteboardWriter.mm
    M Source/WebCore/platform/mac/PlatformEventFactoryMac.mm
    M Source/WebCore/platform/mac/PlatformPasteboardMac.mm
    M Source/WebCore/platform/mac/ScrollViewMac.mm
    M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm
    M Source/WebCore/platform/mac/WidgetMac.mm
    M Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
    M Source/WebCore/platform/mediastream/mac/CGDisplayStreamCaptureSource.cpp
    M Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.mm
    M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDevice.cpp
    M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp
    M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
    M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
    M Source/WebCore/platform/network/cocoa/CookieCocoa.mm
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
    M Source/WebKit/Platform/cocoa/XPCUtilities.mm
    M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
    M Source/WebKit/Shared/Cocoa/APIObject.mm
    M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
    M Source/WebKit/Shared/mac/ObjCObjectGraph.mm
    M Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKConnectionInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm
    M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Gamepad/mac/UIGamepadProviderMac.mm
    M Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm
    M Source/WebKit/UIProcess/ios/WKActionSheet.mm
    M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
    M Source/WebKit/UIProcess/ios/WKContentView.h
    M Source/WebKit/UIProcess/ios/WKContentView.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm
    M Source/WebKit/UIProcess/ios/WKPasswordView.mm
    M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
    M Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm
    M Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm
    M Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
    M Source/WebKit/UIProcess/mac/WKPrintingView.mm
    M Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.mm
    M Source/WebKit/UIProcess/mac/WKTextInputWindowController.mm
    M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
    M Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImplCFNet.cpp
    M Source/WebKitLegacy/mac/History/WebHistory.mm
    M Source/WebKitLegacy/mac/History/WebHistoryItem.mm
    M Source/WebKitLegacy/mac/Misc/WebNSImageExtras.m
    M Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.m
    M Source/WebKitLegacy/mac/Plugins/WebPluginController.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
    M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.mm
    M Source/WebKitLegacy/mac/WebView/WebClipView.mm
    M Source/WebKitLegacy/mac/WebView/WebFrame.mm
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
    M Source/WebKitLegacy/mac/WebView/WebPDFView.mm
    M Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Source/WebKitLegacy/mac/WebView/WebViewRenderingUpdateScheduler.mm
    M Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Coding.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm
    M Tools/TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm
    M Tools/TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm
    M Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm

  Log Message:
  -----------
  Migrate to ALLOW_***_BEGIN/END instead of #pragma clang diagnostic
https://bugs.webkit.org/show_bug.cgi?id=255416
rdar://108011779

Reviewed by Mike Wyrzykowski.

They're better because they're compiler-agnostic.

* Source/JavaScriptCore/disassembler/zydis/Zydis/ZycoreFormat.c:
* Source/WTF/wtf/darwin/OSLogPrintStream.mm:
(WTF::OSLogPrintStream::vprintf):
* Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::contentKeySession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSessionOrGroup):
* Source/WebCore/platform/graphics/cg/NativeImageCG.cpp:
(WebCore::NativeImage::draw):
* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::drawViewlessCell):
(WebCore::drawViewlessCellFocusRing):
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::createArgumentDescriptor):
* Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKShippingContactEditingMode):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::createError):
(WebKit::WebExtension::webProcessDisplayName):
* Source/WebKit/UIProcess/ios/WKContentView.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
(TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
(TEST):
* Tools/TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
(imageFromData):

Canonical link: https://commits.webkit.org/262993@main

More information about the webkit-changes mailing list