[webkit-changes] [WebKit/WebKit] 2e76ca: REGRESSION(262844 at main): css3/filters/reference-fi...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e76ca3e586aac463212f6e0bcb0721fe41596d8
      https://github.com/WebKit/WebKit/commit/2e76ca3e586aac463212f6e0bcb0721fe41596d8
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/WebCore/svg/SVGFETurbulenceElement.cpp

  Log Message:
  -----------
  REGRESSION(262844 at main): css3/filters/reference-filter-change-repaint.html is randomly failing
https://bugs.webkit.org/show_bug.cgi?id=255383

Reviewed by Said Abou-Hallawa.

262844 at main slightly changed the ordering of attribute processing in SVGFETurbulenceElement
and it was caused this repaint test to become flaky. We need to make sure that
SVGFETurbulenceElement::attributeChanged() calls this first:
```
m_seed->setBaseValInternal(newValue.toFloat());
```
when the seed attribute changes, before calling the base class's attributeChanged.

This patch restores the ordering to address the issue.

* Source/WebCore/svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::attributeChanged):

Canonical link: https://commits.webkit.org/262985@main