[webkit-changes] [WebKit/WebKit] 3ea88c: Respond to feedback after 262943 at main

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ea88cae0eed9608777523ae826204f0ba7e2422
      https://github.com/WebKit/WebKit/commit/3ea88cae0eed9608777523ae826204f0ba7e2422
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalFrameProxy.h
    M Source/WebKit/UIProcess/SubframePageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxyInternals.h
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Respond to feedback after 262943 at main
https://bugs.webkit.org/show_bug.cgi?id=255437
rdar://108032616

Reviewed by Chris Dumez.

Chris gave some excellent feedback.  This takes it into account to polish the code a little more.
I also move the maps to WebPageProxy::Internals so we don't have to include an extra header from
WebPageProxy.h.

* Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp:
(WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy):
* Source/WebKit/UIProcess/ProvisionalFrameProxy.h:
* Source/WebKit/UIProcess/SubframePageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::subframePageProxyForFrameID const):
(WebKit::WebPageProxy::addSubframePageProxyForFrameID):
(WebKit::WebPageProxy::registrableDomainForSubframeID const):
(WebKit::WebPageProxy::subpageFrameProxyForRegistrableDomain const):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadRequestByCreatingNewLocalFrameOrConvertingRemoteFrame):

Canonical link: https://commits.webkit.org/262973@main