[webkit-changes] [WebKit/WebKit] 4c8ed9: Assign to self before returning in init methods

[Rose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c8ed9ea14550faa4067caf7e5985a71ee569760
      https://github.com/WebKit/WebKit/commit/4c8ed9ea14550faa4067caf7e5985a71ee569760
  Author: Rose <83477269+AtariDreams at users.noreply.github.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/system/mac/WebPanel.mm
    M Source/WebKit/Shared/Cocoa/WKNSDictionary.mm
    M Source/WebKit/UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm
    M Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm
    M Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm
    M Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm
    M Source/WebKit/UIProcess/ios/forms/WKFormSelectControl.mm
    M Source/WebKit/UIProcess/ios/forms/WKSelectMenuListViewController.mm
    M Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm
    M Source/WebKitLegacy/mac/Misc/WebDownload.mm
    M Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm
    M Source/WebKitLegacy/mac/WebView/WebResource.mm
    M Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm
    M Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm
    M Tools/WebKitTestRunner/mac/WebKitTestRunnerWindow.mm

  Log Message:
  -----------
  Assign to self before returning in init methods
https://bugs.webkit.org/show_bug.cgi?id=255341

Reviewed by Alexey Proskuryakov.

ARC requires this and this is good practice anyway,
even if these files are not being compiled with ARC.

Yes, there were some exceptions simply because reordering
statements in legacy code is too risky/not worth the effort.

* Source/WebCore/PAL/pal/system/mac/WebPanel.mm:
  (-[WebPanel init]):
* Source/WebKit/Shared/Cocoa/WKNSDictionary.mm:
  (-[WKNSDictionary initWithObjects:forKeys:count:]):
* Source/WebKit/UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm:
  (-[WKReloadFrameErrorRecoveryAttempter initWithCoder:]):
* Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:
  (-[WKDatePickerViewController initWithDelegate:]):
* Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:
  (-[WKDateTimeInputControl initWithView:]):
* Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm:
  (-[WKFormColorControl initWithView:]):
* Source/WebKit/UIProcess/ios/forms/WKFormSelectControl.mm:
  (-[WKFormSelectControl initWithView:]):
* Source/WebKit/UIProcess/ios/forms/WKSelectMenuListViewController.mm:
  (-[WKSelectMenuListViewController initWithDelegate:]):
* Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:
  (-[WKTimePickerViewController initWithDelegate:]):
* Source/WebKitLegacy/mac/Misc/WebDownload.mm:
  (-[WebDownload init:]):
* Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm:
  (-[WebIconDatabase init]):
* Source/WebKitLegacy/mac/WebView/WebResource.mm:
  (-[WebResourcePrivate init]):
* Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  (-[DumpRenderTreeDraggingInfo initWithImage:offset:pasteboard:source:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
  (-[MockContentFilterEnabler initWithCoder:]):
* Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
  (-[MockDropSession initWithProviders:location:window:allowMove:]):
  (-[MockDragSession initWithWindow:allowMove:]):
* Tools/WebKitTestRunner/mac/WebKitTestRunnerWindow.mm:
  (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):

Canonical link: https://commits.webkit.org/262971@main