[webkit-changes] [WebKit/WebKit] 9da2b0: Merge ElementName and AttributeName enumerations i...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9da2b02e31a2ba79c73354b04dc59aea0d04bb88
      https://github.com/WebKit/WebKit/commit/9da2b02e31a2ba79c73354b04dc59aea0d04bb88
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/QualifiedName.cpp
    M Source/WebCore/dom/QualifiedName.h
    M Source/WebCore/dom/QualifiedNameCache.cpp
    M Source/WebCore/dom/QualifiedNameCache.h
    M Source/WebCore/dom/make_names.pl
    M Source/WebCore/editing/FormatBlockCommand.cpp
    M Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
    M Source/WebCore/editing/RemoveFormatCommand.cpp
    M Source/WebCore/editing/ReplaceSelectionCommand.cpp
    M Source/WebCore/html/BaseDateAndTimeInputType.cpp
    M Source/WebCore/html/HTMLBodyElement.cpp
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/html/HTMLFormElement.cpp
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLOListElement.cpp
    M Source/WebCore/html/HTMLObjectElement.cpp
    M Source/WebCore/html/HTMLOptionElement.cpp
    M Source/WebCore/html/HTMLSelectElement.cpp
    M Source/WebCore/html/HTMLTableElement.cpp
    M Source/WebCore/html/HTMLTextAreaElement.cpp
    M Source/WebCore/html/parser/HTMLConstructionSite.cpp
    M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp
    M Source/WebCore/html/parser/HTMLStackItem.h
    M Source/WebCore/html/parser/HTMLTreeBuilder.cpp
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/svg/SVGComponentTransferFunctionElement.h
    M Source/WebCore/svg/SVGElement.cpp
    M Source/WebCore/svg/SVGFEComponentTransferElement.cpp
    M Source/WebCore/svg/SVGFilterElement.cpp
    M Source/WebCore/svg/SVGUseElement.cpp

  Log Message:
  -----------
  Merge ElementName and AttributeName enumerations into a single enumeration
https://bugs.webkit.org/show_bug.cgi?id=255420

Reviewed by Darin Adler and Ryosuke Niwa.

Merge ElementName and AttributeName enumerations into a single enumeration named
NodeName. This makes QualifiedName smaller and avoids double lookup when trying
to convert match a QualifiedName to an element or attribute name.

This is based on initial work by Cameron McCormack.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::isElementsArrayReflectionAttribute):
(WebCore::Element::attributeChanged):
(WebCore::canAttachAuthorShadowRoot):
* Source/WebCore/dom/Element.h:
(WebCore::Element::elementName const):
* Source/WebCore/dom/QualifiedName.cpp:
(WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::init):
(WebCore::nullQName):
* Source/WebCore/dom/QualifiedName.h:
(WebCore::QualifiedName::nodeName const):
(WebCore::QualifiedName::elementName const): Deleted.
(WebCore::QualifiedName::attributeName const): Deleted.
* Source/WebCore/dom/QualifiedNameCache.cpp:
(WebCore::updateImplWithNamespaceAndElementName):
(WebCore::QualifiedNameCache::getOrCreate):
* Source/WebCore/dom/QualifiedNameCache.h:
* Source/WebCore/dom/make_names.pl:
(defaultElementPropertyHash):
(defaultAttrPropertyHash):
(byElementNameOrder):
(byAttrNameOrder):
(byElementThenAttrNameOrder):
(printNodeNameHeaderFile):
(printNodeNameCppFile):
(printNamesCppFile):
(printDefinitions):
(printFactoryCppFile):
(printWrapperFactoryCppFile):
(byAttributeNameOrder): Deleted.
(printAttributeNameHeaderFile): Deleted.
(printAttributeNameCppFile): Deleted.
(printElementNameHeaderFile): Deleted.
(printElementNameCppFile): Deleted.
* Source/WebCore/editing/FormatBlockCommand.cpp:
(WebCore::isElementForFormatBlock):
* Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::isPhrasingContent):
* Source/WebCore/editing/RemoveFormatCommand.cpp:
(WebCore::isElementForRemoveFormatCommand):
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::isProhibitedParagraphChild):
* Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::attributeChanged):
* Source/WebCore/html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::hasPresentationalHintsForAttribute const):
(WebCore::HTMLBodyElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::hasPresentationalHintsForAttribute const):
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):
(WebCore::HTMLElement::attributeChanged):
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::attributeChanged):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::hasPresentationalHintsForAttribute const):
(WebCore::HTMLInputElement::collectPresentationalHintsForAttribute):
(WebCore::HTMLInputElement::attributeChanged):
* Source/WebCore/html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::attributeChanged):
* Source/WebCore/html/HTMLObjectElement.cpp:
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::attributeChanged):
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::attributeChanged):
* Source/WebCore/html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::attributeChanged):
* Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::attributeChanged):
* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::qualifiedNameForTag):
(WebCore::qualifiedNameForHTMLTag):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
* Source/WebCore/html/parser/HTMLStackItem.h:
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeEndTag):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::hasEffectiveDisplayNoneForDisplayContents):
* Source/WebCore/svg/SVGComponentTransferFunctionElement.h:
* Source/WebCore/svg/SVGElement.cpp:
(WebCore::isSVGLayerAwareElement):
(WebCore::SVGElement::childShouldCreateRenderer const):
* Source/WebCore/svg/SVGFEComponentTransferElement.cpp:
* Source/WebCore/svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::childShouldCreateRenderer const):
* Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):

Canonical link: https://commits.webkit.org/262969@main