[webkit-changes] [WebKit/WebKit] fdf42a: Fix setSelectorText() to overwrite both selector a...

Matthieu Dubet noreply at github.com
Fri Apr 14 07:05:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fdf42acd549d2f4bef233f855cc9f2c0af9d0a6a
      https://github.com/WebKit/WebKit/commit/fdf42acd549d2f4bef233f855cc9f2c0af9d0a6a
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom.html
    M Source/WebCore/css/CSSStyleRule.cpp
    M Source/WebCore/css/StyleRule.h

  Log Message:
  -----------
  Fix setSelectorText() to overwrite both selector and original selector
https://bugs.webkit.org/show_bug.cgi?id=255446
rdar://108041191

Reviewed by Antti Koivisto.

Before this patch, only the StyleRule selector was overwritten:
selector matching was correct but CSSOM cssText() displayed the wrong selector.

* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom.html:
* Source/WebCore/css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* Source/WebCore/css/StyleRule.h:
(WebCore::StyleRuleWithNesting::wrapperAdoptOriginalSelectorList):

Canonical link: https://commits.webkit.org/262961@main




More information about the webkit-changes mailing list