[webkit-changes] [WebKit/WebKit] c43bba: Cherry-pick 262947 at main (2bab2a58e316). https://bu...

[Adrian Perez]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: c43bba2735577b79aa8d66b4a5a06b1f96a2e90d
      https://github.com/WebKit/WebKit/commit/c43bba2735577b79aa8d66b4a5a06b1f96a2e90d
  Author: Patrick Griffis <pgriffis at igalia.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp

  Log Message:
  -----------
  Cherry-pick 262947 at main (2bab2a58e316). https://bugs.webkit.org/show_bug.cgi?id=255249

    [GLIB] Don't require GApplication for bwrap sandbox
    https://bugs.webkit.org/show_bug.cgi?id=255249

    Reviewed by Adrian Perez de Castro and Carlos Garcia Campos.

    The app-id isn't that important to our usage in our bubblewrap sandbox
    so instead of erroring we can generate an id without any real downsides.

    * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
    (WebKit::applicationId):
    (WebKit::createFlatpakInfo):

    Canonical link: https://commits.webkit.org/262947@main


  Commit: c464add7a23b248b66331532079d86a7f0ae4dc4
      https://github.com/WebKit/WebKit/commit/c464add7a23b248b66331532079d86a7f0ae4dc4
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/WebCore/SourcesGTK.txt
    M Source/WebCore/platform/CaretAnimator.h
    M Source/WebCore/platform/SimpleCaretAnimator.cpp
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/RenderThemeAdwaita.cpp
    M Source/WebCore/rendering/RenderThemeAdwaita.h
    R Source/WebCore/rendering/RenderThemeGtk.cpp
    R Source/WebCore/rendering/RenderThemeGtk.h

  Log Message:
  -----------
  Cherry-pick 262954 at main (6a0a83593474). https://bugs.webkit.org/show_bug.cgi?id=252687

    REGRESSION(257219 at main): [GTK] Cursor blinks oddly in text fields, even if blinking disabled
    https://bugs.webkit.org/show_bug.cgi?id=252687

    Reviewed by Carlos Garcia Campos.

    Before 257219 at main if RenderTheme::caretBlinkInterval() returned zero
    then the timer controlling the blink animation was never started. When
    introducing CaretAnimator + SimpleCaretAnimator the check was not
    carried over, resulting in the animator trying to paint the caret
    on-and-off as fast as possible when blinking should have been disabled.

    The fix reintroduces the check, reusing setBlinkingSuspended() to enable
    (or disable) blinking depending on RenderTheme::caretBlinkInterval(),
    which in turn is changed to return std::optional<Seconds>, with
    std::nullopt signalling that blinking is disables. The improved typing
    ensures that the code explicitly handles the case of blinking being
    disabled.

    While at it, remove the RenderThemeGtk.{h,cpp} files, because they only
    contained an implementation of caretBlinkInterval() that was exactly the
    same code guarded with PLATFORM(GTK) in RenderThemeAdwaita.

    * Source/WebCore/SourcesGTK.txt: Remove RenderThemeGtk.cpp from the list.
    * Source/WebCore/platform/CaretAnimator.h:
    (WebCore::CaretAnimator::didStart): Adapt to use std::optional<Seconds>.
    * Source/WebCore/platform/SimpleCaretAnimator.cpp:
    (WebCore::SimpleCaretAnimator::updateAnimationProperties): Arrange to
    enable or disable caret blinking, adapting to use std::optional<Seconds>.
    * Source/WebCore/rendering/RenderTheme.h:
    (WebCore::RenderTheme::caretBlinkInterval const): Change the return type
    to std::optional<Seconds>.
    * Source/WebCore/rendering/RenderThemeAdwaita.cpp:
    (WebCore::RenderTheme::singleton): Remove PLATFORM(GTK) guard.
    (WebCore::RenderThemeAdwaita::caretBlinkInterval const): Adapt to use
    std::optional<Seconds>.
    * Source/WebCore/rendering/RenderThemeAdwaita.h: Ditto.
    * Source/WebCore/rendering/RenderThemeGtk.cpp: Removed.
    * Source/WebCore/rendering/RenderThemeGtk.h: Removed.

    Canonical link: https://commits.webkit.org/262954@main


Compare: https://github.com/WebKit/WebKit/compare/24676387266c...c464add7a23b