[webkit-changes] [WebKit/WebKit] 8f3ab1: <audio> element counter-scaling causes overlapping...

Dean Jackson noreply at github.com
Fri Apr 14 03:43:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f3ab17c3a9d4ebeea314cb06ff6d99998f073ef
      https://github.com/WebKit/WebKit/commit/8f3ab17c3a9d4ebeea314cb06ff6d99998f073ef
  Author: Dean Jackson <dino at apple.com>
  Date:   2023-04-14 (Fri, 14 Apr 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  <audio> element counter-scaling causes overlapping media elements when page scale is < 1
https://bugs.webkit.org/show_bug.cgi?id=255428
rdar://105846526

Reviewed by Tim Horton.

We counter scale <audio> controls on iOS, which causes them to
escape their element bounds if the user zooms out. Add a setting
to disable this behaviour.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Add a
    new setting AudioControlsScaleWithPageZoom to mirror the generic
    Media setting.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Add
    a test that escapes before setting the value.

Canonical link: https://commits.webkit.org/262952@main




More information about the webkit-changes mailing list