[webkit-changes] [WebKit/WebKit] 0a6033: Check if ShadowRoot nodes are cloneable when extra...

JC Alvarado noreply at github.com
Thu Apr 13 15:44:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a60334817acffa3be8fcf8d9e170fac7c331669
      https://github.com/WebKit/WebKit/commit/0a60334817acffa3be8fcf8d9e170fac7c331669
  Author: JC Alvarado <joncarlo at apple.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M Source/WebCore/dom/Range.cpp

  Log Message:
  -----------
  Check if ShadowRoot nodes are cloneable when extracting a range
https://bugs.webkit.org/show_bug.cgi?id=254842
rdar://106276289

Reviewed by Ryosuke Niwa.

When extracting or cloning a range, we might call cloneNode on a ShadowRoot
that is not cloneable resulting in a release assertion crash. We should skip
nodes that are not cloneable in processAncestorsAndTheirSiblings.

* Source/WebCore/dom/Range.cpp:
(WebCore::processAncestorsAndTheirSiblings):

Canonical link: https://commits.webkit.org/262933@main




More information about the webkit-changes mailing list