[webkit-changes] [WebKit/WebKit] 020a59: Web Inspector: Console: non-enumerable properties ...

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 020a590e7acaecf822bce045a637740dbbc5ed1b
      https://github.com/WebKit/WebKit/commit/020a590e7acaecf822bce045a637740dbbc5ed1b
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css
    M Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js

  Log Message:
  -----------
  Web Inspector: Console: non-enumerable properties appear as though they're internal
https://bugs.webkit.org/show_bug.cgi?id=255376

Reviewed by Patrick Angle.

We currently semi-transparent the text of properties that are not enumerable, but this is most commonly seen as a treatment for internal properties (e.g. `listeners`).

Logging `window` shows all the various builtin constructors (e.g. `AbortController`) with the same treatment, adding further confusion (i.e. "Are these internal properties?  I thought I could access them?").

We should instead move enumerable, writable, etc. to be part of the `title`.

* Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WI.ObjectTreePropertyTreeElement.prototype._createTitlePropertyStyle):
* Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property .property-name:is(.private, .internal)): Renamed from `.object-tree-property .property-name:is(.private, .not-enumerable)`.
Drive-by: Use a CSS variable to change the `color` instead of `opacity`.

* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:

Canonical link: https://commits.webkit.org/262923@main