[webkit-changes] [WebKit/WebKit] 162629: REGRESSION (261193 at main): missing elements on appl...

Tim Nguyen noreply at github.com
Thu Apr 13 11:21:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 162629a2bccd8d5df744faabcd15577828e53c68
      https://github.com/WebKit/WebKit/commit/162629a2bccd8d5df744faabcd15577828e53c68
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/html/HTMLElement.idl
    M Source/WebCore/html/PopoverInvokerElement.idl
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/style/UserAgentStyle.cpp

  Log Message:
  -----------
  REGRESSION (261193 at main): missing elements on apple-console.lrn.com
https://bugs.webkit.org/show_bug.cgi?id=255373
rdar://106779034

Reviewed by Brent Fulgham.

The site uses a popover attribute without the intention of using the popover API, causing the display: none; UA styles to apply.
Quirk the site to have the attribute disabled.

* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
* Source/WebCore/html/HTMLElement.idl:
* Source/WebCore/html/PopoverInvokerElement.idl:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisablePopoverAttributeQuirk const):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

Canonical link: https://commits.webkit.org/262921@main




More information about the webkit-changes mailing list