[webkit-changes] [WebKit/WebKit] 3904de: Missing underline after the first character in con...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3904de11f504acf321715284eed25e8050d41340
      https://github.com/WebKit/WebKit/commit/3904de11f504acf321715284eed25e8050d41340
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderCounter.cpp
    M Source/WebCore/rendering/RenderCounter.h
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderText.h

  Log Message:
  -----------
  Missing underline after the first character in contenteditable
https://bugs.webkit.org/show_bug.cgi?id=255357
<rdar://107846703>

Reviewed by Antti Koivisto.

RenderText's m_min/m_maxWidth values become stale when we dynamically switch over to IFC preferred width computation.
(and sadly these (cached) values are consulted when RenderText::width is called with [0, text-length] range).

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::tryComputePreferredWidthsUsingModernPath):
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths): (forcedMinMaxWidthComputation is to suppress ASSERT)
* Source/WebCore/rendering/RenderCounter.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::minLogicalWidth const):
(WebCore::RenderText::maxLogicalWidth const):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width const):
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::resetMinMaxWidth):

Canonical link: https://commits.webkit.org/262914@main