[webkit-changes] [WebKit/WebKit] 59c22d: [JSC] MSVC miscompiles PropertyCatchalls_setProper...

[Ross Kirsling]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59c22d8e9fd410926949b88437b0eb7a46cdce49
      https://github.com/WebKit/WebKit/commit/59c22d8e9fd410926949b88437b0eb7a46cdce49
  Author: Ross Kirsling <rkirsling at gmail.com>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M Source/JavaScriptCore/API/tests/testapi.c

  Log Message:
  -----------
  [JSC] MSVC miscompiles PropertyCatchalls_setProperty in testapi.c
https://bugs.webkit.org/show_bug.cgi?id=255331

Reviewed by Mark Lam.

Windows fails testapi.c in release mode with "PropertyCatchalls.x should be 4 but instead is 3".

MSVC seems to be doing some invalid inlining of the static local `count` variable, yet somehow changing the code
in almost any way fixes the issue. In particular, we can even *simplify* the relevant code!

* Source/JavaScriptCore/API/tests/testapi.c:
(PropertyCatchalls_setProperty):

Canonical link: https://commits.webkit.org/262899@main