[webkit-changes] [WebKit/WebKit] 2ca55a: Make document.applets always return an empty list

Anne van Kesteren noreply at github.com
Wed Apr 12 12:09:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ca55a3e19df60127dec09f3af22e4d3ab2943ec
      https://github.com/WebKit/WebKit/commit/2ca55a3e19df60127dec09f3af22e4d3ab2943ec
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/shadow-dom/leaktests/html-collection-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/shadow-dom/leaktests/html-collection.html
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/html/CollectionType.h
    M Source/WebCore/html/GenericCachedHTMLCollection.cpp
    M Source/WebCore/html/HTMLCollection.cpp
    M Source/WebCore/html/HTMLObjectElement.cpp
    M Source/WebCore/html/HTMLObjectElement.h

  Log Message:
  -----------
  Make document.applets always return an empty list
https://bugs.webkit.org/show_bug.cgi?id=255326
rdar://107926196

Reviewed by Myles C. Maxfield.

Replace DocApplets with DocEmpty that never matches any node. Also remove containsJavaApplet() as it's no longer called by anything.

* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/leaktests/html-collection-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/leaktests/html-collection.html:

Upstreamed via https://github.com/web-platform-tests/wpt/pull/39499.

* Source/WebCore/dom/Document.cpp:
(WebCore::canAccessAncestor):
(WebCore::Document::sharedLogger):
(WebCore::Document::removedLastRef):
(WebCore::Document::adoptNode):
(WebCore::Document::setTitle):
(WebCore::Document::resolveStyle):
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
(WebCore::Document::removeAllEventListeners):
(WebCore::Document::axObjectCache const):
(WebCore::Document::hasHighlight const):
(WebCore::Document::updateHighlightPositions):
(WebCore::Document::implicitClose):
(WebCore::Document::setURL):
(WebCore::Document::processReferrerPolicy):
(WebCore::Document::runScrollSteps):
(WebCore::Document::updateIsPlayingMedia):
(WebCore::Document::focusNavigationStartingNode const):
(WebCore::Document::applets):
(WebCore::Document::finishedParsing):
(WebCore::Document::statePopped):
(WebCore::Document::initDNSPrefetch):
(WebCore::Document::resumeScheduledTasks):
(WebCore::Document::absoluteEventHandlerBounds):
(WebCore::Document::updateLastHandledUserGestureTimestamp):
(WebCore::Document::loader const):
(WebCore::Document::convertAbsoluteToClientRects):
(WebCore::Document::convertAbsoluteToClientRect):
(WebCore::expandRootBoundsWithRootMargin):
(WebCore::computeClippedRectInRootContentsSpace):
(WebCore::Document::contentChangeObserver):
* Source/WebCore/html/CollectionType.h:
* Source/WebCore/html/GenericCachedHTMLCollection.cpp:
(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches const):
* Source/WebCore/html/HTMLCollection.cpp:
(WebCore::HTMLCollection::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::isSupportedPropertyName):
* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::containsJavaApplet const): Deleted.
* Source/WebCore/html/HTMLObjectElement.h:

Canonical link: https://commits.webkit.org/262879@main




More information about the webkit-changes mailing list