[webkit-changes] [WebKit/WebKit] 4190c0: [IFC] Incorrect vertical positioning when ideograp...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4190c03e5516e769572766eb25f64c7c2cde55fb
      https://github.com/WebKit/WebKit/commit/4190c03e5516e769572766eb25f64c7c2cde55fb
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    A LayoutTests/fast/inline/ideographic-baseline-with-vertical-align-expected.html
    A LayoutTests/fast/inline/ideographic-baseline-with-vertical-align.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp

  Log Message:
  -----------
  [IFC] Incorrect vertical positioning when ideographic baseline is present
https://bugs.webkit.org/show_bug.cgi?id=255224

Reviewed by Antti Koivisto.

Descent needs adjustment when picking ideographic baseline to be able to align the box correctly. Note that it is normally 0 for atomic inline boxes (in horizontal writing mode).

* LayoutTests/fast/inline/ideographic-baseline-with-vertical-align-expected.html: Added.
* LayoutTests/fast/inline/ideographic-baseline-with-vertical-align.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustIdeographicBaselineIfApplicable):

Canonical link: https://commits.webkit.org/262868@main