[webkit-changes] [WebKit/WebKit] 14be4a: AX: Create TextMarkerRanges based on the TextConte...

AndresGonzalezApple noreply at github.com
Tue Apr 11 13:14:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 14be4a13b9fa5db5a902153bb694bea79072e0c7
      https://github.com/WebKit/WebKit/commit/14be4a13b9fa5db5a902153bb694bea79072e0c7
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-04-11 (Tue, 11 Apr 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm

  Log Message:
  -----------
  AX: Create TextMarkerRanges based on the TextContent of AXIsolatedObjects.
https://bugs.webkit.org/show_bug.cgi?id=255286
<rdar://problem/107883608>

Reviewed by Tyler Wilcock.

TextMarkerRanges were created using the cached AttributedString for some types of AXIsoaltedObjects. However, we need to create TesxtMarkerRanges for objects for which there is no cached AttributedString. This patch uses the TextContent property instead of the cached AttributedString.

AccessibilityObject::textContent is now retrieving the text from the object's range using TextIterators. This will be extended to other text representation for other types of objects like images, buttons, etc.

This is needed to implement AXIsolatedObject::stringForTextMarkerRange and related methods off the main thtread.

Canonical link: https://commits.webkit.org/262835@main




More information about the webkit-changes mailing list