[webkit-changes] [WebKit/WebKit] 6513ac: REGRESSION(262774 at main): [ iOS ] editing/selection...

Richard Robinson noreply at github.com
Tue Apr 11 09:46:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6513acfa9782b7e68516ec2606653f4d0ed74d95
      https://github.com/WebKit/WebKit/commit/6513acfa9782b7e68516ec2606653f4d0ed74d95
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-04-11 (Tue, 11 Apr 2023)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  -----------
  REGRESSION(262774 at main): [ iOS ] editing/selection/ios/selection-handles-in-readonly-input.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=255261
rdar://107860599

Reviewed by Wenson Hsieh.

262774 at main accidentally changed the logic of some selection logic due to the early return in
`WebKit::WebPage::getPlatformEditorStateCommon`.

This PR fixes this by modifying the early return to ensure consistency with how this logic worked
previously.

* LayoutTests/platform/ios/TestExpectations:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::getPlatformEditorStateCommon const):

Canonical link: https://commits.webkit.org/262828@main




More information about the webkit-changes mailing list