[webkit-changes] [WebKit/WebKit] 7baa7b: Avoid unnecessary StyleColor copying in animation ...

Antti Koivisto noreply at github.com
Tue Apr 11 05:22:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7baa7bfbdcd3a44864124f78e7b67bf73f868722
      https://github.com/WebKit/WebKit/commit/7baa7bfbdcd3a44864124f78e7b67bf73f868722
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-04-11 (Tue, 11 Apr 2023)

  Changed paths:
    M Source/WebCore/animation/CSSPropertyAnimation.cpp

  Log Message:
  -----------
  Avoid unnecessary StyleColor copying in animation wrappers
https://bugs.webkit.org/show_bug.cgi?id=255278
rdar://107875297

Reviewed by Antoine Quint.

There is some unnecessary copying of this not-quite-trivial type.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperStyleColor::PropertyWrapperStyleColor):
(WebCore::PropertyWrapperStyleColor::value const):

Remove templating and have separate classes for StyleColor and Color cases.

(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::value const):
(WebCore::PropertyWrapperVisitedAffectedStyleColor::PropertyWrapperVisitedAffectedStyleColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
(WebCore::PropertyWrapperColor::unresolvedValue const): Deleted.

Canonical link: https://commits.webkit.org/262822@main




More information about the webkit-changes mailing list