[webkit-changes] [WebKit/WebKit] b8ca1c: AX: Defer handling children changes for dynamic ar...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8ca1cf1bd0f47dd2889abae65b87c2bb2527520
      https://github.com/WebKit/WebKit/commit/b8ca1cf1bd0f47dd2889abae65b87c2bb2527520
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html
    M LayoutTests/accessibility/mac/iframe-aria-hidden-expected.txt
    M LayoutTests/accessibility/mac/iframe-aria-hidden.html
    M Source/WebCore/accessibility/AXObjectCache.cpp

  Log Message:
  -----------
  AX: Defer handling children changes for dynamic aria-hidden attribute updates
https://bugs.webkit.org/show_bug.cgi?id=255245
rdar://107589985

Reviewed by Chris Fleizach.

It can be unsafe to update the accessibility trees eagerly from AXObjectCache::handleAttributeChange
because layout and style can be dirty. Deferring this update may also help us be more efficient by
de-duping children updates with the inherent hash set properties of m_pendingChildrenUpdates.

Because aria-hidden changes no longer eagerly update the isolated tree, aria-hidden-changes-for-non-ignored-elements.html
and iframe-aria-hidden.html had to be updated to properly wait for AX tree updates after dynamic aria-hidden changes.

* LayoutTests/accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html:
* LayoutTests/accessibility/mac/iframe-aria-hidden-expected.txt:
* LayoutTests/accessibility/mac/iframe-aria-hidden.html:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):

Canonical link: https://commits.webkit.org/262804@main