[webkit-changes] [WebKit/WebKit] 0f2621: [CSS Fonts] Implement the from-font value for font...

ChangSeok Oh noreply at github.com
Mon Apr 10 19:18:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f2621d762162b939c8959ba3aa4f4a3af8452df
      https://github.com/WebKit/WebKit/commit/0f2621d762162b939c8959ba3aa4f4a3af8452df
  Author: ChangSeok Oh <changseok at webkit.org>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/platform/graphics/FontSizeAdjust.h
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleFontSizeFunctions.cpp
    M Source/WebCore/style/StyleFontSizeFunctions.h

  Log Message:
  -----------
  [CSS Fonts] Implement the from-font value for font-size-adjust
https://bugs.webkit.org/show_bug.cgi?id=254790

Reviewed by Myles C. Maxfield and Tim Nguyen.

The 'from-font' value is newly added to CSS Font Module Level 5 [1], which allows
the browser to automatically determine a font-size-adjust value based on the primary font.
This change implements it.

The following tests have merged into the latest WPT [2] and are backported in this patch.

Test:
    imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html
    imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html
    imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid.html
    imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html

[1] https://www.w3.org/TR/css-fonts-5/#valdef-font-size-adjust-from-font
[2] https://github.com/web-platform-tests/wpt/pull/39380

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFontSizeAdjust):
* Source/WebCore/platform/graphics/FontSizeAdjust.h:
(WebCore::FontSizeAdjust::operator== const):
(WebCore::operator<<):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontSizeAdjust):
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
(WebCore::Style::aspectValueOfPrimaryFont):
* Source/WebCore/style/StyleFontSizeFunctions.h:

Canonical link: https://commits.webkit.org/262800@main




More information about the webkit-changes mailing list