[webkit-changes] [WebKit/WebKit] d7cdf9: REGRESSION(261193 at main): Context menu on AnkiApp i...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7cdf9321324d8175db36836fe0fab5d38508ad5
      https://github.com/WebKit/WebKit/commit/d7cdf9321324d8175db36836fe0fab5d38508ad5
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
    M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
    M Source/WebKit/Shared/WebPreferencesDefaultValues.h
    M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h
    M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm

  Log Message:
  -----------
  REGRESSION(261193 at main): Context menu on AnkiApp is hidden
https://bugs.webkit.org/show_bug.cgi?id=255252
rdar://106810768

Reviewed by Tim Horton.

AnkiApp (https://apps.apple.com/us/app/ankiapp-flashcards/id689185915) has its context menu wrongly hidden because it uses the popover attribute
which now has display: none by default in the UA styles.

To fix this, disable the popover attribute feature in apps linked with older SDKs.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultPopoverAttributeEnabled):
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h:
* Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultPopoverAttributeEnabled):

Canonical link: https://commits.webkit.org/262797@main