[webkit-changes] [WebKit/WebKit] 1cc30e: Correct PDF Plugin descriptions returned by naviga...

Brent Fulgham noreply at github.com
Mon Apr 10 11:43:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cc30ed20c2570c0d4b67c6c71a9b92d2a21c85c
      https://github.com/WebKit/WebKit/commit/1cc30ed20c2570c0d4b67c6c71a9b92d2a21c85c
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    A LayoutTests/dom/html/navigator-plugins-expected.txt
    A LayoutTests/dom/html/navigator-plugins.html
    M Source/WebCore/page/Navigator.cpp

  Log Message:
  -----------
  Correct PDF Plugin descriptions returned by navigator.plugins[x].description
https://bugs.webkit.org/show_bug.cgi?id=255155
<rdar://problem/107756651>

Reviewed by Geoffrey Garen.

In Bug 254189 we corrected a bug where the name of the WebKit Built-in PDF plugin was localized
for the user's settings, which confused some anti-fraud software because the specification requires
the name to be in plain English text.

While that issue was fixed, the specification also requires a consistent English label, "Portable
Document Format" be returned by the 'description' property of the plugin. This is currently localized
in Safari, leading to some anti-fraud software failing.

This patch modifies only the return value from Navigator.plugins[].description, so that other
elements of the Browser UI can correctly localize the description.

* Source/WebCore/page/Navigator.cpp:
(WebCore::Navigator::initializePluginAndMimeTypeArrays):

Canonical link: https://commits.webkit.org/262779@main




More information about the webkit-changes mailing list