[webkit-changes] [WebKit/WebKit] afa7e1: [IFC][line-box-contain] line-height should not aff...

Alan Baradlay noreply at github.com
Mon Apr 10 07:42:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: afa7e183e513a79a15da3ad042d37b304f026057
      https://github.com/WebKit/WebKit/commit/afa7e183e513a79a15da3ad042d37b304f026057
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    A LayoutTests/fast/inline/line-box-contain-with-line-height-expected.html
    A LayoutTests/fast/inline/line-box-contain-with-line-height.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp

  Log Message:
  -----------
  [IFC][line-box-contain] line-height should not affect enclosing height
https://bugs.webkit.org/show_bug.cgi?id=255211

Reviewed by Antti Koivisto.

Layout bounds geometry takes line-height into account potentially causing overlapping content
while line-box-contain (by definition) should always produce non-overlapping content.

* LayoutTests/fast/inline/line-box-contain-with-line-height-expected.html: Added.
* LayoutTests/fast/inline/line-box-contain-with-line-height.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustInlineBoxHeightsForLineBoxContainIfApplicable):

Canonical link: https://commits.webkit.org/262768@main




More information about the webkit-changes mailing list