[webkit-changes] [WebKit/WebKit] 6650e9: JSTests: lower memory threshold to enable a test o...

Guillaume Emont noreply at github.com
Fri Apr 7 15:39:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6650e9c47294f97c018fea3f330608f6e6c0763a
      https://github.com/WebKit/WebKit/commit/6650e9c47294f97c018fea3f330608f6e6c0763a
  Author: Guillaume Emont <guijemont at igalia.com>
  Date:   2023-04-07 (Fri, 07 Apr 2023)

  Changed paths:
    M JSTests/wasm/stress/only-referenced.js
    M JSTests/wasm/stress/resources/only-referenced.wasm

  Log Message:
  -----------
  JSTests: lower memory threshold to enable a test on Arm
https://bugs.webkit.org/show_bug.cgi?id=255146

Reviewed by Yusuke Suzuki.

By lowering the size of the shared memory, we ensure that it is always
less than MAX_ARRAY_BUFFER_SIZE (0x7fffffff on 32-bit).

This is the diff on the wat matching only-referenced.wasm:

    @@ -41,7 +41,7 @@
       (func (;7;) (type 5)
         return)
       (table (;0;) 91 687 externref)
    -  (memory (;0;) 43254 65536 shared)
    +  (memory (;0;) 21627 32767 shared)
       (global (;4;) (mut i32) (i32.const -1297171695))
       (global (;5;) (mut externref) (ref.null extern))
       (global (;6;) (mut f64) (f64.const 0x1.2ea8c95ef0395p+975 (;=3.77537e+293;)))

Wabt's wasm2wat and wat2wasm were used to disassemble and reassemble
only-referenced.wasm.

* JSTests/wasm/stress/only-referenced.js: Only skipp if platform does
  not support wasm or we're running in memory limited mode
* JSTests/wasm/stress/resources/only-referenced.wasm: Lower size of
  shared memory

Canonical link: https://commits.webkit.org/262731@main




More information about the webkit-changes mailing list