[webkit-changes] [WebKit/WebKit] abf098: REGRESSION(259818 at main...259759@main?): CSS variab...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abf098f7f5b062eb6853824155c2c6d3711e0996
      https://github.com/WebKit/WebKit/commit/abf098f7f5b062eb6853824155c2c6d3711e0996
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    A LayoutTests/http/tests/svg/resources/st-search.svg
    A LayoutTests/http/tests/svg/use-custom-property-inheritance-expected.html
    A LayoutTests/http/tests/svg/use-custom-property-inheritance.html
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/StyleResolver.h
    M Source/WebCore/svg/SVGElement.cpp

  Log Message:
  -----------
  REGRESSION(259818 at main...259759@main?): CSS variables are not applied to the SVG use element's shadow tree
https://bugs.webkit.org/show_bug.cgi?id=254549
rdar://107295588

Reviewed by Ryosuke Niwa.

We fail to inherit custom properties to <use> element shadow tree in the specific case where
the targeted element is the root element of an external SVG document.

* LayoutTests/http/tests/svg/resources/st-search.svg: Added.
* LayoutTests/http/tests/svg/use-custom-property-inheritance-expected.html: Added.
* LayoutTests/http/tests/svg/use-custom-property-inheritance.html: Added.
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::styleForElement):

Don't suppress property inheritance for the document element in the case we are resolving a <use> tree root.

* Source/WebCore/style/StyleResolver.h:
* Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::resolveCustomStyle):

Canonical link: https://commits.webkit.org/262698@main