[webkit-changes] [WebKit/WebKit] 9fc3af: SVGPathSegValue::clone<>() rename to SVGPathSegVal...

Said Abou-Hallawa noreply at github.com
Thu Apr 6 16:23:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9fc3aff2f3870364e33a99d82b67f2372472167f
      https://github.com/WebKit/WebKit/commit/9fc3aff2f3870364e33a99d82b67f2372472167f
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    M Source/WebCore/svg/SVGPathSeg.h
    M Source/WebCore/svg/SVGPathSegImpl.h
    M Source/WebCore/svg/SVGPathSegValue.h

  Log Message:
  -----------
  SVGPathSegValue::clone<>() rename to SVGPathSegValue::cloneInternal<>()
https://bugs.webkit.org/show_bug.cgi?id=254757
rdar://107719787

Reviewed by Michael Catanzaro.

GCC 13 considers the template function SVGPathSegValue::clone<>() hides the virtual
function SVGPathSeg::clone<>() so the SVGPathSegValue super-classes can't override it.

Renaming it will make the classes in SVGPathSegValueImpl.h be complied on GCC 13
without the need for -Woverloaded-virtual.

* Source/WebCore/svg/SVGPathSeg.h:
* Source/WebCore/svg/SVGPathSegImpl.h:
* Source/WebCore/svg/SVGPathSegValue.h:
(WebCore::SVGPathSegValue::cloneInternal const):
(WebCore::SVGPathSegValue::clone const): Deleted.

Canonical link: https://commits.webkit.org/262690@main




More information about the webkit-changes mailing list