[webkit-changes] [WebKit/WebKit] 15f924: Enable telemetry to debug top crash below JSModule...

Commit Queue noreply at github.com
Thu Apr 6 14:58:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 15f92441853330bf7133cb96f066fac13dc8ce9e
      https://github.com/WebKit/WebKit/commit/15f92441853330bf7133cb96f066fac13dc8ce9e
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSModuleRecord.cpp

  Log Message:
  -----------
  Enable telemetry to debug top crash below JSModuleRecord::instantiateDeclarations
https://bugs.webkit.org/show_bug.cgi?id=255089
rdar://107644069

Reviewed by Mark Lam.

In 262608 at main (79f0773): https://commits.webkit.org/262608@main, we landed a
speculative mitigation against an unexplained crash where an AbstractModuleRecord
pointer somehow got the same value jsUndefined. The speculative crash mitigation
also added some Debug ASSERTs to help collect some bread crumb data about what
went wrong to lead to this crash. This patch turns these Debug ASSERTs into
RELEASE_ASSERTs to capture the telemetry data to help us diagnose this mysterious
crash.

* Source/JavaScriptCore/runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::instantiateDeclarations):

Canonical link: https://commits.webkit.org/262687@main




More information about the webkit-changes mailing list