[webkit-changes] [WebKit/WebKit] fd2baf: Be less aggressive about setting timeout during HT...

Matthew Finkel noreply at github.com
Thu Apr 6 12:34:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd2bafc1772ad6dbd9dfd19a212d70fc6e40dc44
      https://github.com/WebKit/WebKit/commit/fd2bafc1772ad6dbd9dfd19a212d70fc6e40dc44
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm

  Log Message:
  -----------
  Be less aggressive about setting timeout during HTTPSOnly
https://bugs.webkit.org/show_bug.cgi?id=254640
rdar://107074579

Reviewed by Alex Christensen.

In the first iteration, we set a 3 second timeout interval on the request when
the HTTPSOnly policy is enabled. The 3 second timeout is a little too
aggressive, and that timeout is also currently set on all requests instead of
only main resource loads. This change now reduces the scope where the timeout
is set, and increases the timeout to 10 seconds based on some experience.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::upgradeRequestforHTTPSOnlyIfNeeded const):
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

Canonical link: https://commits.webkit.org/262678@main




More information about the webkit-changes mailing list