[webkit-changes] [WebKit/WebKit] 63e18b: MathML element in "display: flex" is not repainted...

Alan Baradlay noreply at github.com
Thu Apr 6 11:53:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63e18b5e9ecd265902784d50ab46c37766aa2543
      https://github.com/WebKit/WebKit/commit/63e18b5e9ecd265902784d50ab46c37766aa2543
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    A LayoutTests/fast/repaint/mathm-gains-new-content-blank-expected.txt
    A LayoutTests/fast/repaint/mathm-gains-new-content-blank.html
    M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLMath.cpp
    M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp

  Log Message:
  -----------
  MathML element in "display: flex" is not repainted on content change.
https://bugs.webkit.org/show_bug.cgi?id=254722

Reviewed by Antti Koivisto.

1. RenderMathMLBlock::layoutItems -> this is similar to what other FCs do on first layout (i.e. full repaint) -see RenderFlexibleBox::layoutAndPlaceChildren, RenderBlockflow::layoutBlockChild.
2. RenderMathMLMath::centerChildren/layoutRowItems -> introduce some generic repaint logic when things get moved around.

* LayoutTests/fast/repaint/mathm-gains-new-content-blank-expected.txt: Added.
* LayoutTests/fast/repaint/mathm-gains-new-content-blank.html: Added.
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::layoutItems):

Canonical link: https://commits.webkit.org/262674@main




More information about the webkit-changes mailing list