[webkit-changes] [WebKit/WebKit] ef3245: [css-grid] grid-template-rows: masonry has an effe...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef3245fe7ca023957930d1836c543b5522db91eb
      https://github.com/WebKit/WebKit/commit/ef3245fe7ca023957930d1836c543b5522db91eb
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  -----------
  [css-grid] grid-template-rows: masonry has an effect, even when the feature is turned off
https://bugs.webkit.org/show_bug.cgi?id=255022

Reviewed by Matt Woodrow.

Missing a check to verify whether Masonry is enabled or not. This should be refactored in the future
as having to check the context everywhere is not great, but this does fix the bug.

The reason masonry was being triggered was the RenderStyle masonryRows are getting populated due to the missing check.
When we go to layout the block we do a check if it is masonry or not. Since the masonryRows got populated we assume that
we should do a masonry layout instead of a grid layout.

Reviewed manually turning on and off the flag.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeGridTrackList):

Canonical link: https://commits.webkit.org/262670@main