[webkit-changes] [WebKit/WebKit] 96af04: REGRESSION (iOS 16.4): Our page crashes on page lo...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 96af04c5e6b2f257ec424cf11c12721886d19fe3
      https://github.com/WebKit/WebKit/commit/96af04c5e6b2f257ec424cf11c12721886d19fe3
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    A LayoutTests/http/wpt/service-workers/controlled-module-dedicatedworker.https-expected.txt
    A LayoutTests/http/wpt/service-workers/controlled-module-dedicatedworker.https.html
    A LayoutTests/http/wpt/service-workers/module-dedicatedworker-worker.js
    A LayoutTests/http/wpt/service-workers/resources/controlled-module-worker.js
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp

  Log Message:
  -----------
  REGRESSION (iOS 16.4): Our page crashes on page load due to service workers
https://bugs.webkit.org/show_bug.cgi?id=254938
rdar://problem/107602025

Reviewed by Chris Dumez.

We are thinking module worker loads are main worker load and were expecting to get a resulting client identifier but got none.
Check on the resulting client identifier to identify whether the request is for a new client.
Covered by newly added test in Debug.

* LayoutTests/http/wpt/service-workers/controlled-module-dedicatedworker.https-expected.txt: Added.
* LayoutTests/http/wpt/service-workers/controlled-module-dedicatedworker.https.html: Added.
* LayoutTests/http/wpt/service-workers/module-dedicatedworker-worker.js: Added.
(async doTest):
* LayoutTests/http/wpt/service-workers/resources/controlled-module-worker.js: Added.
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::controlClient):
(WebKit::WebSWServerConnection::createFetchTask):

Canonical link: https://commits.webkit.org/262666@main