[webkit-changes] [WebKit/WebKit] d31d84: Ensure Win JSC can run complex.yaml tests

Ross Kirsling noreply at github.com
Thu Apr 6 00:45:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d31d8491766b5f7149b5a3594eb4ce48b7fe0229
      https://github.com/WebKit/WebKit/commit/d31d8491766b5f7149b5a3594eb4ce48b7fe0229
  Author: Ross Kirsling <ross.kirsling at sony.com>
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
    M JSTests/complex.yaml
    M Source/JavaScriptCore/jsc.cpp

  Log Message:
  -----------
  Ensure Win JSC can run complex.yaml tests
https://bugs.webkit.org/show_bug.cgi?id=255078

Reviewed by Yusuke Suzuki.

Making this test suite work on Windows boils down to fixing two problems:

1. The tests which don't set env vars are passing an empty string, but in Ruby, this is appended to a list ($envVars),
   meaning that we end up trying to set a env var with key "". Use nil instead.

2. On Windows, TZ isn't a magic env var, so:
   a. Have jsc.cpp call setTimeZoneOverride instead.
   b. Skip temporal-now-timezone-with-broken-tz.js.
      (Obviously we could call setTimeZoneOverride with "UTC" if (a) fails,
      but it would serve no purpose, as this behavior has nothing to do with Temporal.)

* JSTests/complex.yaml:
* Source/JavaScriptCore/jsc.cpp:

Canonical link: https://commits.webkit.org/262659@main




More information about the webkit-changes mailing list