[webkit-changes] [WebKit/WebKit] 62b9ab: No videos play if opened in full screen on first play

Per Arne Vollan noreply at github.com
Wed Apr 5 19:34:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62b9ab75af70fc1cb9ada689c9f3f482a0274e30
      https://github.com/WebKit/WebKit/commit/62b9ab75af70fc1cb9ada689c9f3f482a0274e30
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2023-04-05 (Wed, 05 Apr 2023)

  Changed paths:
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

  Log Message:
  -----------
  No videos play if opened in full screen on first play
https://bugs.webkit.org/show_bug.cgi?id=255048
rdar://107540521

Reviewed by Eric Carlson and Jean-Yves Avenard.

When CA layers are not remotely hosted in both the GPU process and the WebContent process, it is not
guaranteed that the remote context ID will be set in the HTML media element when entering fullscreen.
This patch works around that by delaying setting up the fullscreen until the video dimensions are set.
At this point, the remote context ID should be available.

* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h:
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::videoDimensionsChanged):

Canonical link: https://commits.webkit.org/262654@main




More information about the webkit-changes mailing list