[webkit-changes] [WebKit/WebKit] 2cd8ae: AX: Make AccessibilityNodeObject::m_node hold a We...
Tyler Wilcock
noreply at github.com
Wed Apr 5 02:15:49 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2cd8ae7e10eaf832abdf698c3701dde4990fe045
https://github.com/WebKit/WebKit/commit/2cd8ae7e10eaf832abdf698c3701dde4990fe045
Author: Tyler Wilcock <tyler_w at apple.com>
Date: 2023-04-05 (Wed, 05 Apr 2023)
Changed paths:
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
Log Message:
-----------
AX: Make AccessibilityNodeObject::m_node hold a WeakPtr<Node>
https://bugs.webkit.org/show_bug.cgi?id=255005
rdar://107589983
Reviewed by Chris Fleizach.
Let's bring AccessibilityNodeObject in line with https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines
to improve memory safety.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityNodeObject::correspondingLabelForControlElement const):
(WebCore::AccessibilityNodeObject::labelElementContainer const):
(WebCore::AccessibilityNodeObject::exposesTitleUIElement const):
(WebCore::AccessibilityNodeObject::description const):
(WebCore::AccessibilityNodeObject::isFocused const):
(WebCore::AccessibilityNodeObject::setFocused):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
Canonical link: https://commits.webkit.org/262614@main
More information about the webkit-changes
mailing list