[webkit-changes] [WebKit/WebKit] 05a628: REGRESSION(262547 at main): Multiple layout tests cra...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05a6289e70ae984d1d119eac630651b4adb7ea94
      https://github.com/WebKit/WebKit/commit/05a6289e70ae984d1d119eac630651b4adb7ea94
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-04-04 (Tue, 04 Apr 2023)

  Changed paths:
    M Source/WebKit/Shared/ShareableBitmap.cpp
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm

  Log Message:
  -----------
  REGRESSION(262547 at main): Multiple layout tests crash when decoding a null ShareableBitmapHandle
https://bugs.webkit.org/show_bug.cgi?id=255001
rdar://107625511

Reviewed by Simon Fraser.

Remove an assertion from one of the constructors of ShareableBitmapConfiguration
so the ones which were created by the default constructor can be decoded.

Also this uncovered a bug in WebPageProxy::platformCloneAttachment() when the
thumbnail size is empty. So this should bail out.

* Source/WebKit/Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmapConfiguration::ShareableBitmapConfiguration):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::convertPlatformImageToBitmap):

Canonical link: https://commits.webkit.org/262599@main