[webkit-changes] [WebKit/WebKit] 0b1da7: [WPE] Always call glBindAttribLocation before glLi...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b1da7fc6eb2c1cc6c016b93c762235cd1752cc3
      https://github.com/WebKit/WebKit/commit/0b1da7fc6eb2c1cc6c016b93c762235cd1752cc3
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2023-04-04 (Tue, 04 Apr 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp
    M Tools/wpe/backends/fdo/WindowViewBackend.cpp

  Log Message:
  -----------
  [WPE] Always call glBindAttribLocation before glLinkProgram
https://bugs.webkit.org/show_bug.cgi?id=255006

Reviewed by Don Olmstead.

Reorder glBindAttribLocation() calls to be done before glLinkProgram().
While existing code worked with many GL implementations, that behavior
shall not be relied upon: the specification indicates that attribute
bindings go into effect after calling glLinkProgram().

Thanks to user "mizmar" for reporting the issue and outlining the
solution.

* Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:
(WPEQtViewBackend::WPEQtViewBackend): Reorder GL calls.
* Tools/wpe/backends/fdo/WindowViewBackend.cpp:
(WPEToolingBackends::WindowViewBackend::WindowViewBackend): Ditto.

Canonical link: https://commits.webkit.org/262592@main