[webkit-changes] [WebKit/WebKit] fc5e0e: REGRESSION(262518 at main) [cairo] Crash under Graphi...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc5e0e6a297b4373a182086c9e862323fd70abaa
      https://github.com/WebKit/WebKit/commit/fc5e0e6a297b4373a182086c9e862323fd70abaa
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-04-04 (Tue, 04 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/NativeImage.h
    M Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp
    M Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp

  Log Message:
  -----------
  REGRESSION(262518 at main) [cairo] Crash under GraphicsContextGL::paintToCanvas
https://bugs.webkit.org/show_bug.cgi?id=254942

Reviewed by Kimmo Kinnunen.

GraphicsContextGL::createNativeImageFromPixelBuffer creates a
NativeImage from a PixelBuffer. The NativeImage object has to retain
the given PixelBuffer. CG port is using CGDataProviderCreateWithData
to do that. However, cairo image surface can't attach a user data.
Added a new member variable of PixelBuffer to NativeImage only for
cairo port.

* Source/WebCore/platform/graphics/NativeImage.h:
* Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:
(WebCore::GraphicsContextGL::createNativeImageFromPixelBuffer):
* Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::NativeImage::create):
(WebCore::NativeImage::NativeImage):

Canonical link: https://commits.webkit.org/262575@main