[webkit-changes] [WebKit/WebKit] bb7a5e: GraphicsContextGLANGLE duplicates constructor and ...

Kimmo Kinnunen noreply at github.com
Tue Apr 4 00:48:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb7a5ea543d43ce804a674d3be33353763881d1b
      https://github.com/WebKit/WebKit/commit/bb7a5ea543d43ce804a674d3be33353763881d1b
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-04-04 (Tue, 04 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
    M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Source/WebCore/platform/graphics/gbm/GraphicsContextGLANGLELinux.cpp
    M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp

  Log Message:
  -----------
  GraphicsContextGLANGLE duplicates constructor and accessors across platforms
https://bugs.webkit.org/show_bug.cgi?id=254907
rdar://problem/107548342

Reviewed by Matt Woodrow.

Move the trivial implementations to shared GraphicsContextGLANGLE.
Remove unused *direct functions.

* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLANGLE::compileShaderDirect): Deleted.
(WebCore::GraphicsContextGLANGLE::texImage2DDirect): Deleted.
(WebCore::GraphicsContextGLANGLE::getAttribLocationDirect): Deleted.
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLANGLE::~GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE): Deleted.
(WebCore::GraphicsContextGLANGLE::platformDisplay const): Deleted.
(WebCore::GraphicsContextGLANGLE::platformConfig const): Deleted.
* Source/WebCore/platform/graphics/gbm/GraphicsContextGLANGLELinux.cpp:
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE): Deleted.
(WebCore::GraphicsContextGLANGLE::platformDisplay const): Deleted.
(WebCore::GraphicsContextGLANGLE::platformConfig const): Deleted.
* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE): Deleted.
(WebCore::GraphicsContextGLANGLE::platformDisplay const): Deleted.
(WebCore::GraphicsContextGLANGLE::platformConfig const): Deleted.

Canonical link: https://commits.webkit.org/262571@main




More information about the webkit-changes mailing list