[webkit-changes] [WebKit/WebKit] 6d83f8: (REGRESSION 258589 at main) Slow typing in large GitH...

Richard Robinson noreply at github.com
Mon Apr 3 17:48:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d83f81564a51d2fd489d84817ffda2433828e4c
      https://github.com/WebKit/WebKit/commit/6d83f81564a51d2fd489d84817ffda2433828e4c
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt
    M Source/WebKit/Shared/EditorState.h
    M Source/WebKit/Shared/EditorState.serialization.in
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  (REGRESSION 258589 at main) Slow typing in large GitHub review
https://bugs.webkit.org/show_bug.cgi?id=254858
rdar://107377754

Reviewed by Alan Baradlay.

Reverts most of 258589 at main, which turns out isn't actually needed at all and was apparently
causing more harm than good, since it resulted in heavy calculations in each editor state change.

* Source/WebKit/Shared/EditorState.h:
* Source/WebKit/Shared/EditorState.serialization.in:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::getPlatformEditorStateCommon const):
(WebKit::WebPage::clickableNodeAtLocation const): Deleted.
(WebKit::WebPage::isTransparentOrFullyClipped const): Deleted.
(WebKit::WebPage::getEvasionRectsAroundSelection const): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::isTransparentOrFullyClipped const):
(WebKit::WebPage::requestEvasionRectsAboveSelection):

Canonical link: https://commits.webkit.org/262550@main




More information about the webkit-changes mailing list