[webkit-changes] [WebKit/WebKit] c9e619: Refactor some network connection integrity code

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9e61964956a8cb9edc38279a8d8084b3e737d99
      https://github.com/WebKit/WebKit/commit/c9e61964956a8cb9edc38279a8d8084b3e737d99
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M Source/WebCore/page/LookalikeCharactersSanitizationData.h
    M Source/WebKit/Platform/cocoa/NetworkConnectionIntegrityHelpers.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Refactor some network connection integrity code
https://bugs.webkit.org/show_bug.cgi?id=254893
rdar://107535003

Reviewed by Megan Gardner.

See below for more details.

* Source/WebCore/page/LookalikeCharactersSanitizationData.h:
(WebCore::LookalikeCharactersSanitizationData::LookalikeCharactersSanitizationData):

Add a missing `WTFMove` on the given rvalue reference for `domain`, and implement:
- The copy constructor and assignment operator.
- The move constructor and assignment operator.
...for the `LookalikeCharactersSanitizationData` class.

(WebCore::LookalikeCharactersSanitizationData::operator=):
* Source/WebKit/Platform/cocoa/NetworkConnectionIntegrityHelpers.h:

Change this helper to pass back a `Vector&&` instead of `const Vector&`.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateAllowedLookalikeCharacterStringsIfNeeded):

Add `mutable` to a lambda blocks where we use `WTFMove` on the argument.

Canonical link: https://commits.webkit.org/262529@main