[webkit-changes] [WebKit/WebKit] bc8d5b: REGRESSION(258561 at main): :user-valid/:user-invalid...

Commit Queue noreply at github.com
Mon Apr 3 10:23:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc8d5b0f582f1f25dd48a6d84f51aeb29dd1e20b
      https://github.com/WebKit/WebKit/commit/bc8d5b0f582f1f25dd48a6d84f51aeb29dd1e20b
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-invalid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-valid.html
    A LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/selectors/user-invalid-expected.txt
    A LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/selectors/user-valid-expected.txt
    M Source/WebCore/html/HTMLFormControlElement.h

  Log Message:
  -----------
  REGRESSION(258561 at main): :user-valid/:user-invalid stopped working
https://bugs.webkit.org/show_bug.cgi?id=254571
<rdar://problem/107300848>

Reviewed by Tim Nguyen.

This change adds missing virtual method overrides to fix :user-valid / :user-invalid
pseudoclasses, similar to those we have for :valid / :invalid.
They are necessary because ValidatedFormListedElement doesn't inherit from Element.

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/user-valid.html:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/selectors/user-invalid-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/selectors/user-valid-expected.txt:
* Source/WebCore/html/HTMLFormControlElement.h:

Co-authored-by: Tim Nguyen <ntim at apple.com>

Canonical link: https://commits.webkit.org/262512@main




More information about the webkit-changes mailing list